Implement layout of NTP apps promo.

Implement layout of NTP apps promo. Subsequent changes will
show it at the correct time.

BUG=53972
TEST=chrome --force-apps-promo-visible, open NTP. Should see promo.

[Aaron Boodman, 2010-10-06 19:52:22]

Screen cap here: http://imgur.com/hukyu

[Bons, 2010-10-06 20:04:06]

LGTM

http://codereview.chromium.org/3538014/diff/1/4
File chrome/browser/resources/new_new_tab.html (right):

http://codereview.chromium.org/3538014/diff/1/4#newcode137
chrome/browser/resources/new_new_tab.html:137: <button id="apps-promo-hide"
i18n-content="appspromohide"></button>
isn't it semantically equivalent to say
<button ..... /> instead of having the closing tags below?

http://codereview.chromium.org/3538014/diff/1/5
File chrome/browser/resources/new_new_tab.js (right):

http://codereview.chromium.org/3538014/diff/1/5#newcode1098
chrome/browser/resources/new_new_tab.js:1098: 
remove extra line (I don't see any other instances of two newlines in this
file).

http://codereview.chromium.org/3538014/diff/1/7
File chrome/browser/resources/ntp/apps.css (right):

http://codereview.chromium.org/3538014/diff/1/7#newcode109
chrome/browser/resources/ntp/apps.css:109: #apps-promo > h3 {
do we care that this is inefficient as a selector?

http://codereview.chromium.org/3538014/diff/1/7#newcode143
chrome/browser/resources/ntp/apps.css:143: html[appspromovisible=true]
.app[app-id=web-store-entry] a {
this too

[arv (Not doing code reviews), 2010-10-06 20:48:36]

FYI

http://codereview.chromium.org/3538014/diff/1/4
File chrome/browser/resources/new_new_tab.html (right):

http://codereview.chromium.org/3538014/diff/1/4#newcode137
chrome/browser/resources/new_new_tab.html:137: <button id="apps-promo-hide"
i18n-content="appspromohide"></button>
On 2010/10/06 20:04:06, Andrew Bonventre (Bons) wrote:
> isn't it semantically equivalent to say
> <button ..... /> instead of having the closing tags below?

No, HTML does not have /> and required end tags are always required.

http://codereview.chromium.org/3538014/diff/1/5
File chrome/browser/resources/new_new_tab.js (right):

http://codereview.chromium.org/3538014/diff/1/5#newcode1103
chrome/browser/resources/new_new_tab.js:1103: promoText1.innerHTML =
promoText1.textContent;
You can do this using the template system

<p id="apps-promo-text1" i18n-values=".innerHTML:appspromotext1"></p>

http://codereview.chromium.org/3538014/diff/1/7
File chrome/browser/resources/ntp/apps.css (right):

http://codereview.chromium.org/3538014/diff/1/7#newcode109
chrome/browser/resources/ntp/apps.css:109: #apps-promo > h3 {
On 2010/10/06 20:04:06, Andrew Bonventre (Bons) wrote:
> do we care that this is inefficient as a selector?

This is not inefficient. Direct descendant selectors are efficient.

also, the inefficient selector history is mostly in Gecko. WebKit does not have
the same performance issue with descendant selectors as Gecko does.

[Bons, 2010-10-06 21:02:23]

Got it. Thanks Arv!