Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5491)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/new_new_tab.html

Issue 3538014: Implement layout of NTP apps promo. (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/ntp_resource_cache.cc ('k') | chrome/browser/resources/new_new_tab.js » ('j') | chrome/browser/resources/new_new_tab.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/new_new_tab.html
diff --git a/chrome/browser/resources/new_new_tab.html b/chrome/browser/resources/new_new_tab.html
index 8700500de10543d9ff47aa6ca34eb92cfc320985..186c4cfa999b230bdd652edb0f7de1ae801a3a36 100644
--- a/chrome/browser/resources/new_new_tab.html
+++ b/chrome/browser/resources/new_new_tab.html
@@ -5,7 +5,8 @@
hasattribution:hasattribution;
anim:anim;
syncispresent:syncispresent;
- customlogo:customlogo"
+ customlogo:customlogo;
+ appspromovisible:appspromovisible"
install-animation-enabled="true">
<head>
<meta charset="utf-8">
@@ -131,7 +132,14 @@ if ('mode' in hashParams) {
<span class="link"><span class="link-color"></span></span>
</div>
- <div class="maxiview" id="apps-maxiview"></div>
+ <div class="maxiview" id="apps-maxiview">
+ <div id="apps-promo">
+ <button id="apps-promo-hide" i18n-content="appspromohide"></button>
Bons 2010/10/06 20:04:06 isn't it semantically equivalent to say <button ..
arv (Not doing code reviews) 2010/10/06 20:48:36 No, HTML does not have /> and required end tags ar
+ <h3 i18n-content="appspromoheader"></h3>
+ <p id="apps-promo-text1" i18n-content="appspromotext1"></p>
+ <p id="apps-promo-text2" i18n-content="appspromotext2"></p>
+ </div>
+ </div>
<div class="maxiview" id="most-visited-maxiview"></div>
<div class="sections">
« no previous file with comments | « chrome/browser/dom_ui/ntp_resource_cache.cc ('k') | chrome/browser/resources/new_new_tab.js » ('j') | chrome/browser/resources/new_new_tab.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698