chrome/browser/resources/new_new_tab.html - Issue 3538014: Implement layout of NTP apps promo.

Side by Side Diff: chrome/browser/resources/new_new_tab.html

Issue 3538014: Implement layout of NTP apps promo. (Closed) Base URL: git://codf21.jail/chromium.git

Patch Set: Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html i18n-values="	2 <html i18n-values="

3 dir:textdirection;	3 dir:textdirection;

4 bookmarkbarattached:bookmarkbarattached;	4 bookmarkbarattached:bookmarkbarattached;

5 hasattribution:hasattribution;	5 hasattribution:hasattribution;

6 anim:anim;	6 anim:anim;

7 syncispresent:syncispresent;	7 syncispresent:syncispresent;

8 customlogo:customlogo"	8 customlogo:customlogo;

	9 appspromovisible:appspromovisible"

9 install-animation-enabled="true">	10 install-animation-enabled="true">

10 <head>	11 <head>

11 <meta charset="utf-8">	12 <meta charset="utf-8">

12 <title i18n-content="title"></title>	13 <title i18n-content="title"></title>

13 <script>	14 <script>

14 // Logging info for benchmarking purposes.	15 // Logging info for benchmarking purposes.

15 var log = [];	16 var log = [];

16 function logEvent(name, shouldLogTime) {	17 function logEvent(name, shouldLogTime) {

17 if (shouldLogTime) {	18 if (shouldLogTime) {

18 chrome.send('logEventTime', [name]);	19 chrome.send('logEventTime', [name]);

(...skipping 105 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
124 <img id="attribution-img">	125 <img id="attribution-img">

125 </div>	126 </div>

126	127

127 <div id="main">	128 <div id="main">

128	129

129 <div id="notification">	130 <div id="notification">

130 <span> </span>	131 <span> </span>

131 <span class="link"><span class="link-color"></span></span>	132 <span class="link"><span class="link-color"></span></span>

132 </div>	133 </div>

133	134

134 <div class="maxiview" id="apps-maxiview"></div>	135 <div class="maxiview" id="apps-maxiview">

	136 <div id="apps-promo">

	137 <button id="apps-promo-hide" i18n-content="appspromohide"></button>
	Bons 2010/10/06 20:04:06 isn't it semantically equivalent to say <button .. isn't it semantically equivalent to say <button ..... /> instead of having the closing tags below? arv (Not doing code reviews) 2010/10/06 20:48:36 No, HTML does not have /> and required end tags ar Show quoted text On 2010/10/06 20:04:06, Andrew Bonventre (Bons) wrote: > isn't it semantically equivalent to say > <button ..... /> instead of having the closing tags below? No, HTML does not have /> and required end tags are always required.
	138 <h3 i18n-content="appspromoheader"></h3>

	139 <p id="apps-promo-text1" i18n-content="appspromotext1"></p>

	140 <p id="apps-promo-text2" i18n-content="appspromotext2"></p>

	141 </div>

	142 </div>

135 <div class="maxiview" id="most-visited-maxiview"></div>	143 <div class="maxiview" id="most-visited-maxiview"></div>

136	144

137 <div class="sections">	145 <div class="sections">

138 <!-- Start disabled. We only enable if we have at least one app. -->	146 <!-- Start disabled. We only enable if we have at least one app. -->

139 <div id="apps" class="section disabled" section="APPS">	147 <div id="apps" class="section disabled" section="APPS">

140 <h2>	148 <h2>

141 <img class="disclosure" img src="ntp/ntp_disclosure_triangle.png">	149 <img class="disclosure" img src="ntp/ntp_disclosure_triangle.png">

142 <div class="back"></div>	150 <div class="back"></div>

143 <span i18n-content="apps"></span>	151 <span i18n-content="apps"></span>

144 <button class="section-close-button"></button>	152 <button class="section-close-button"></button>

(...skipping 133 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
278 setSectionVisible('apps', Section.APPS, appsInitiallyVisible, MINIMIZED_APPS);	286 setSectionVisible('apps', Section.APPS, appsInitiallyVisible, MINIMIZED_APPS);

279 setSectionVisible(	287 setSectionVisible(

280 'most-visited', Section.THUMB,	288 'most-visited', Section.THUMB,

281 mostVisitedInitiallyVisible, MINIMIZED_THUMB);	289 mostVisitedInitiallyVisible, MINIMIZED_THUMB);

282 setSectionVisible(	290 setSectionVisible(

283 'recently-closed', undefined,	291 'recently-closed', undefined,

284 recentlyClosedInitiallyVisible, MINIMIZED_RECENT);	292 recentlyClosedInitiallyVisible, MINIMIZED_RECENT);

285 layoutSections();	293 layoutSections();

286 </script>	294 </script>

287 </html>	295 </html>

OLD	NEW

« no previous file with comments | « chrome/browser/dom_ui/ntp_resource_cache.cc ('k') | chrome/browser/resources/new_new_tab.js » ('j') | chrome/browser/resources/new_new_tab.js » ('J')