src/x64/ic-x64.cc - Issue 3520006: Do not invoke indexed interceptor getters for negative indices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/ic-x64.cc

Issue 3520006: Do not invoke indexed interceptor getters for negative indices. (Closed)

Patch Set: Addressing Vitaly concern Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/ic-x64.cc

diff --git a/src/x64/ic-x64.cc b/src/x64/ic-x64.cc

index 62e769123ebf9e658f7f37fc9067408ca4b78747..47d4c938739705bebe1f5229deb0efa046f57086 100644

--- a/src/x64/ic-x64.cc

+++ b/src/x64/ic-x64.cc

@@ -893,8 +893,8 @@ void KeyedLoadIC::GenerateIndexedInterceptor(MacroAssembler* masm) {

// Check that the receiver isn't a smi.

__ JumpIfSmi(rdx, &slow);

- // Check that the key is a smi.

- __ JumpIfNotSmi(rax, &slow);

+ // Check that the key is an array index, that is Uint32.

+ __ JumpIfNotPositiveSmi(rax, &slow);

// Get the map of the receiver.

__ movq(rcx, FieldOperand(rdx, HeapObject::kMapOffset));

« no previous file with comments | « src/stub-cache.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »