Fix leak of a DownloadItem in SavePackage::Init.

Fix leak of a DownloadItem in SavePackage::Init.

BUG=56495, 54149
TEST=valgrind, see bugs

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60439

[Paweł Hajdan Jr., 2010-09-23 12:58:23]

Looks like my http://codereview.chromium.org/3442003 was so broken. :-/

[Bernhard Bauer, 2010-09-23 13:07:46]

LGTM with a nit:

http://codereview.chromium.org/3498002/diff/1/2
File chrome/browser/download/save_package.cc (right):

http://codereview.chromium.org/3498002/diff/1/2#newcode378
chrome/browser/download/save_package.cc:378:
download_manager->SavePageAsDownloadStarted(download_);
Could you add a comment to DownloadManager::SavePageAsDownloadStarted saying
that the DownloadManager takes ownership of the DownloadItem?

[Bernhard Bauer, 2010-09-23 13:11:04]

http://codereview.chromium.org/3498002/diff/1/2
File chrome/browser/download/save_package.cc (right):

http://codereview.chromium.org/3498002/diff/1/2#newcode378
chrome/browser/download/save_package.cc:378:
download_manager->SavePageAsDownloadStarted(download_);
And maybe here as well, so that it's clear that we're not leaking the
DownloadItem here.

[ahendrickson, 2010-09-23 17:09:36]

LGTM.

On 2010/09/23 13:11:04, Bernhard Bauer wrote:
> http://codereview.chromium.org/3498002/diff/1/2
> File chrome/browser/download/save_package.cc (right):
> 
> http://codereview.chromium.org/3498002/diff/1/2#newcode378
> chrome/browser/download/save_package.cc:378:
> download_manager->SavePageAsDownloadStarted(download_);
> And maybe here as well, so that it's clear that we're not leaking the
> DownloadItem here.