Regression fix: keep the download shelf visible when multiple sites are saved.

Regression fix: keep the download shelf visible when multiple sites are saved.

BUG=54149
TEST=see bug

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60034

[Paweł Hajdan Jr., 2010-09-15 18:49:15]

Please note I'm not really happy with the fix. It's the simplest and safest way
I could find to fix the bug.

I'm not sure if it's caused by one of my cleanup changes. In theory it could be,
I can check more if needed.

[ahendrickson, 2010-09-15 19:59:31]

So the download shelf will be visible until shutdown?

On 2010/09/15 18:49:15, Paweł Hajdan Jr. wrote:
> Please note I'm not really happy with the fix. It's the simplest and safest
way
> I could find to fix the bug.
> 
> I'm not sure if it's caused by one of my cleanup changes. In theory it could
be,
> I can check more if needed.

[Paweł Hajdan Jr., 2010-09-15 20:20:01]

The shelf will not auto-close by clicking the save-as second time. If the
user closes it, it will keep closed.

On Wed, Sep 15, 2010 at 12:59, <ahendrickson@chromium.org> wrote:

> So the download shelf will be visible until shutdown?
>
>
> On 2010/09/15 18:49:15, Paweł Hajdan Jr. wrote:
>
>> Please note I'm not really happy with the fix. It's the simplest and
>> safest
>>
> way
>
>> I could find to fix the bug.
>>
>
>  I'm not sure if it's caused by one of my cleanup changes. In theory it
>> could
>>
> be,
>
>> I can check more if needed.
>>
>
>
>
> http://codereview.chromium.org/3442003/show
>

[Paweł Hajdan Jr., 2010-09-16 17:19:37]

ping

[Paweł Hajdan Jr., 2010-09-17 18:28:40]

ping

[Paweł Hajdan Jr., 2010-09-20 13:29:10]

piiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiing!

This fixes a Priority 1 Milestone 7 bug.

[ahendrickson, 2010-09-20 15:52:13]

LGTM, though I wish we could come up with a better way.

I don't see this causing any problems, at least.

On 2010/09/20 13:29:10, Paweł Hajdan Jr. wrote:
> piiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiing!
> 
> This fixes a Priority 1 Milestone 7 bug.