chrome/browser/download/download_manager.h - Issue 3498002: Fix leak of a DownloadItem in SavePackage::Init.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_manager.h

Issue 3498002: Fix leak of a DownloadItem in SavePackage::Init. (Closed)

Patch Set: rebase Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_manager.h

diff --git a/chrome/browser/download/download_manager.h b/chrome/browser/download/download_manager.h

index f4dc78d7ae13626d22bb5bd4c98a9d99d97c530f..4bbf49aa02fe9416304f46ff26136115050049ba 100644

--- a/chrome/browser/download/download_manager.h

+++ b/chrome/browser/download/download_manager.h

@@ -135,7 +135,8 @@ class DownloadManager

// deleted is returned back to the caller.

int RemoveAllDownloads();

- // Called when a Save Page As download is started.

+ // Called when a Save Page As download is started. Transfers ownership

+ // of |download_item| to the DownloadManager.

void SavePageAsDownloadStarted(DownloadItem* download_item);

// Download the object at the URL. Used in cases such as "Save Link As..."

« no previous file with comments | « no previous file | chrome/browser/download/save_package.cc » ('j') | no next file with comments »