Issue 347019: Convert ReplaceStringPlaceholders(std::string...) to take a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 347019: Convert ReplaceStringPlaceholders(std::string...) to take a (Closed)

Created:
11 years, 1 month ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Convert ReplaceStringPlaceholders(std::string...) to take a StringPiece as the format string instead. This allows us to save a string copy in the new tab page. Also clean up some code in the extensions process binding that was doing excess string conversions. BUG=26228 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30491

Patch Set 1 #

Patch Set 2 : a #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -20 lines)			Patch
M	app/l10n_util.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	base/string_util.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/string_util.cc	View	2 chunks	+8 lines, -10 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_theme_source.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/renderer/extensions/extension_process_bindings.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages