base/string_util.h - Issue 347019: Convert ReplaceStringPlaceholders(std::string...) to take a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/string_util.h

Issue 347019: Convert ReplaceStringPlaceholders(std::string...) to take a (Closed)

Patch Set: a Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/string_util.h

diff --git a/base/string_util.h b/base/string_util.h

index f128f99f8498ccf2c78190d2def05f1d84e4bda8..1c58e91990a8a4e8a250d4f72af406de54427469 100644

--- a/base/string_util.h

+++ b/base/string_util.h

@@ -550,7 +550,7 @@ string16 ReplaceStringPlaceholders(const string16& format_string,

const std::vector<string16>& subst,

std::vector<size_t>* offsets);

-std::string ReplaceStringPlaceholders(const std::string& format_string,

+std::string ReplaceStringPlaceholders(const base::StringPiece& format_string,

const std::vector<std::string>& subst,

std::vector<size_t>* offsets);

« no previous file with comments | « app/l10n_util.cc ('k') | base/string_util.cc » ('j') | no next file with comments »