Convert ReplaceStringPlaceholders(std::string...) to take a

app/l10n_util.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/l10n_util.h"
 
 #include <cstdlib>
 #include "app/app_paths.h"
 #include "app/app_switches.h"
 #include "app/gfx/canvas.h"
@@ skipping 507 matching lines @@
   ResourceBundle& rb = ResourceBundle::GetSharedInstance();
   return rb.GetLocalizedString(message_id);
 }
 
 static string16 GetStringF(int message_id,
                            const string16& a,
                            const string16& b,
                            const string16& c,
                            const string16& d,
                            std::vector<size_t>* offsets) {
+  // TODO(tc): We could save a string copy if we got the raw string as
+  // a StringPiece and were able to call ReplaceStringPlaceholders with
+  // a StringPiece format string and string16 substitution strings.  In
+  // practice, the strings should be relatively short.
   ResourceBundle& rb = ResourceBundle::GetSharedInstance();
   const string16& format_string = rb.GetLocalizedString(message_id);
   std::vector<string16> subst;
   subst.push_back(a);
   subst.push_back(b);
   subst.push_back(c);
   subst.push_back(d);
   string16 formatted = ReplaceStringPlaceholders(format_string, subst,
                                                  offsets);
   return formatted;
@@ skipping 493 matching lines @@
 }
 
 void BiDiLineIterator::GetLogicalRun(int start,
                                      int* end,
                                      UBiDiLevel* level) {
   DCHECK(bidi_ != NULL);
   ubidi_getLogicalRun(bidi_, start, end, level);
 }
 
 }