Issue 347012: Add a CHECK() around the SharedMemory ftruncate() call to finger it as a cras...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 347012: Add a CHECK() around the SharedMemory ftruncate() call to finger it as a cras... (Closed)

Created:
11 years, 1 month ago by hawk

Modified:
9 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, brettw+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a CHECK() around the SharedMemory ftruncate() call to finger it as a crash culprit. BUG=16371 TEST=Check the crash logs to see if this CHECK() supplants the CHECK() failure in AsyncResourceHandler::OnWillRead() Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30530

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	base/shared_memory_posix.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

hawk

The ftruncate() call is the leading candidate for the root cause of the crash in ...

11 years, 1 month ago (2009-10-29 22:28:49 UTC) #1

lgtm

Expand Messages | Collapse Messages