Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 159730: Do not cache an IOBuffer in AsyncResourceHandler if data_ is NULL. (Closed)

Created:
11 years, 4 months ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

CHECK that IOBuffer::data_ in AsyncResourceHandler is not NULL before caching it. BUG=http://crbug.com/16371 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22214

Patch Set 1 #

Total comments: 1

Patch Set 2 : Switch to CHECK. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/renderer_host/async_resource_handler.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
willchan no longer on Chromium
http://code.google.com/p/chromium/issues/detail?id=17363 has an example of a user hitting [6073:6078:165451373342:FATAL:/b/slave/chrome-official-linux/build/src/chrome/browser/renderer_host/async_resource_handler.cc(86)] Check failed: read_buffer_->data(). I'm not sure ...
11 years, 4 months ago (2009-07-31 21:29:42 UTC) #1
rvargas (doing something else)
http://codereview.chromium.org/159730/diff/1/2 File chrome/browser/renderer_host/async_resource_handler.cc (right): http://codereview.chromium.org/159730/diff/1/2#newcode145 Line 145: NOTREACHED() << "http://crbug.com/16371"; I think we actually have ...
11 years, 4 months ago (2009-07-31 21:54:56 UTC) #2
willchan no longer on Chromium
Switched to CHECK and updated the description.
11 years, 4 months ago (2009-07-31 22:04:53 UTC) #3
rvargas (doing something else)
11 years, 4 months ago (2009-07-31 22:06:53 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698