New event style for pageAction API....

New event style for pageAction API.

This makes us fire both the old deprecated style of pageActions click handler and the new pageAction style. 

BUG=25833
TEST=none

[Matt Perry, 2009-10-28 23:41:13]

mostly lgtm

http://codereview.chromium.org/346006/diff/1/2
File chrome/browser/extensions/extension_browser_event_router.cc (right):

http://codereview.chromium.org/346006/diff/1/2#newcode96
Line 96: static void DispatchTabContentsEvent(Profile* profile,
This name was confusing to me. How about DispatchEventWithTab?

http://codereview.chromium.org/346006/diff/1/7
File chrome/test/data/extensions/api_test/old_page_actions/background.html
(right):

http://codereview.chromium.org/346006/diff/1/7#newcode10
Line 10: chrome.test.notifyFail("pageActions listener failed");
should this be in an else?

[asargent_no_longer_on_chrome, 2009-10-29 17:56:41]

http://codereview.chromium.org/346006/diff/1/2
File chrome/browser/extensions/extension_browser_event_router.cc (right):

http://codereview.chromium.org/346006/diff/1/2#newcode96
Line 96: static void DispatchTabContentsEvent(Profile* profile,
On 2009/10/28 23:41:14, Matt Perry wrote:
> This name was confusing to me. How about DispatchEventWithTab?

Done.

http://codereview.chromium.org/346006/diff/1/7
File chrome/test/data/extensions/api_test/old_page_actions/background.html
(right):

http://codereview.chromium.org/346006/diff/1/7#newcode10
Line 10: chrome.test.notifyFail("pageActions listener failed");
On 2009/10/28 23:41:14, Matt Perry wrote:
> should this be in an else?

Good catch. It turns out to have happened to work, but might have caused weird
bugs later on if the test was extended or the C++ side of the
chrome.test.notify{Pass,Fail} code changed in some way.

[Matt Perry, 2009-10-29 18:07:31]

lgtm