Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: chrome/renderer/resources/extension_process_bindings.js

Issue 346006: New event style for pageAction API.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extension_process_bindings.js
===================================================================
--- chrome/renderer/resources/extension_process_bindings.js (revision 30461)
+++ chrome/renderer/resources/extension_process_bindings.js (working copy)
@@ -192,12 +192,16 @@
// Page action events send (pageActionId, {tabId, tabUrl}).
function setupPageActionEvents(extensionId) {
var pageActions = GetCurrentPageActions(extensionId);
- var eventName = "pageAction/" + extensionId;
+
+ var oldStyleEventName = "pageActions/" + extensionId;
// TODO(EXTENSIONS_DEPRECATED): only one page action
for (var i = 0; i < pageActions.length; ++i) {
// Setup events for each extension_id/page_action_id string we find.
- chrome.pageActions[pageActions[i]] = new chrome.Event(eventName);
+ chrome.pageActions[pageActions[i]] = new chrome.Event(oldStyleEventName);
}
+
+ // Note this is singular.
+ var eventName = "pageAction/" + extensionId;
chrome.pageAction = chrome.pageAction || {};
chrome.pageAction.onClicked = new chrome.Event(eventName);
}

Powered by Google App Engine
This is Rietveld 408576698