Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1647)

Unified Diff: chrome/browser/extensions/page_action_apitest.cc

Issue 346006: New event style for pageAction API.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/page_action_apitest.cc
===================================================================
--- chrome/browser/extensions/page_action_apitest.cc (revision 30461)
+++ chrome/browser/extensions/page_action_apitest.cc (working copy)
@@ -42,7 +42,8 @@
{
// Simulate the page action being clicked.
ResultCatcher catcher;
- int tab_id = ExtensionTabUtil::GetTabId(browser()->GetSelectedTabContents());
+ int tab_id =
+ ExtensionTabUtil::GetTabId(browser()->GetSelectedTabContents());
ExtensionBrowserEventRouter::GetInstance()->PageActionExecuted(
browser()->profile(), extension->id(), "", tab_id, "", 0);
EXPECT_TRUE(catcher.GetNextResult());
@@ -60,3 +61,34 @@
tab_id = browser()->GetSelectedTabContents()->controller().session_id().id();
EXPECT_FALSE(action->GetIcon(tab_id).isNull());
}
+
+
+// Tests old-style pageActions API that is deprecated but we don't want to
+// break.
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, OldPageActions) {
+ ASSERT_TRUE(RunExtensionTest("old_page_actions")) << message_;
+
+ ExtensionsService* service = browser()->profile()->GetExtensionsService();
+ ASSERT_EQ(1u, service->extensions()->size());
+ Extension* extension = service->extensions()->at(0);
+ ASSERT_TRUE(extension);
+
+ // Have the extension enable the page action.
+ {
+ ResultCatcher catcher;
+ ui_test_utils::NavigateToURL(browser(),
+ GURL(extension->GetResourceURL("page.html")));
+ ASSERT_TRUE(catcher.GetNextResult());
+ }
+
+ // Simulate the page action being clicked.
+ {
+ ResultCatcher catcher;
+ int tab_id =
+ ExtensionTabUtil::GetTabId(browser()->GetSelectedTabContents());
+ ExtensionBrowserEventRouter::GetInstance()->PageActionExecuted(
+ browser()->profile(), extension->id(), "action", tab_id, "", 1);
+ EXPECT_TRUE(catcher.GetNextResult());
+ }
+}
+
Property changes on: chrome\browser\extensions\page_action_apitest.cc
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « chrome/browser/extensions/extension_browser_event_router.cc ('k') | chrome/renderer/resources/extension_process_bindings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698