Issue 3455027: [Mac] Do not insert an "About Chrome" item when the Wrench menu shows an available update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3455027: [Mac] Do not insert an "About Chrome" item when the Wrench menu shows an available update. (Closed)

Created:
10 years, 2 months ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, PhistucK

CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

[Mac] Do not insert an "About Chrome" item when the Wrench menu shows an available update. Changes to the WrenchMenuModel have made |-[WrenchMenuController insertUpdateAvailableItem]| obsolete. The Upgrade item is now inserted when the menu is built but is just marked as hidden; the About item is now distinct and never inserted on Mac. BUG=56023 TEST=Be out of date with 1 window open. Wait for the upgrade ball to appear. Open the Wrench menu and do not see an "About Chrome" item. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60695

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -35 lines)			Patch
M	chrome/browser/cocoa/toolbar_controller.mm	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/wrench_menu_controller.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/wrench_menu_controller.mm	View	1 chunk	+0 lines, -30 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

Do you think this is safe for M7? Having that no-op About item is really ...

10 years, 2 months ago (2010-09-26 20:16:30 UTC) #1

PhistucK

On 2010/09/26 20:16:30, rsesek wrote: > Do you think this is safe for M7? Having ...

10 years, 2 months ago (2010-09-27 07:50:56 UTC) #2

LGTM

Expand Messages | Collapse Messages