Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3780)

Unified Diff: chrome/browser/cocoa/wrench_menu_controller.mm

Issue 3455027: [Mac] Do not insert an "About Chrome" item when the Wrench menu shows an available update. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/wrench_menu_controller.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/wrench_menu_controller.mm
diff --git a/chrome/browser/cocoa/wrench_menu_controller.mm b/chrome/browser/cocoa/wrench_menu_controller.mm
index 49661570aa3749a517e05328756cc34702a45ba3..3c76d920e35b2d1e69ed171952d7a10ebd30c9f3 100644
--- a/chrome/browser/cocoa/wrench_menu_controller.mm
+++ b/chrome/browser/cocoa/wrench_menu_controller.mm
@@ -169,36 +169,6 @@ class ZoomLevelObserver : public NotificationObserver {
return static_cast<WrenchMenuModel*>(model_);
}
-// Inserts the update available notification menu item.
-- (void)insertUpdateAvailableItem {
- WrenchMenuModel* model = [self wrenchMenuModel];
- // Don't insert the item multiple times.
- if (!model || model->GetIndexOfCommandId(IDC_ABOUT) != -1)
- return;
-
- // Update the model manually because the model is static because other
- // platforms always have an About item.
- int index = model->GetIndexOfCommandId(IDC_OPTIONS) + 1;
- model->InsertItemAt(index, IDC_ABOUT,
- l10n_util::GetStringFUTF16(IDS_ABOUT,
- l10n_util::GetStringUTF16(IDS_PRODUCT_NAME)));
-
- // The model does not broadcast change notifications to its delegate, so
- // insert the actual menu item ourselves.
- NSInteger menuIndex = [[self menu] indexOfItemWithTag:index];
- [self addItemToMenu:[self menu]
- atIndex:menuIndex
- fromModel:model
- modelIndex:index];
-
- // Since the tag of each menu item is the index within the model, they need
- // to be adjusted after insertion.
- for (NSInteger i = menuIndex + 1; i < [[self menu] numberOfItems]; ++i) {
- NSMenuItem* item = [[self menu] itemAtIndex:i];
- [item setTag:[item tag] + 1];
- }
-}
-
// Fit the localized strings into the Cut/Copy/Paste control, then resize the
// whole menu item accordingly.
- (void)adjustPositioning {
« no previous file with comments | « chrome/browser/cocoa/wrench_menu_controller.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698