Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: chrome/browser/cocoa/wrench_menu_controller.h

Issue 3455027: [Mac] Do not insert an "About Chrome" item when the Wrench menu shows an available update. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_COCOA_WRENCH_MENU_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_COCOA_WRENCH_MENU_CONTROLLER_H_
6 #define CHROME_BROWSER_COCOA_WRENCH_MENU_CONTROLLER_H_ 6 #define CHROME_BROWSER_COCOA_WRENCH_MENU_CONTROLLER_H_
7 #pragma once 7 #pragma once
8 8
9 #import <Cocoa/Cocoa.h> 9 #import <Cocoa/Cocoa.h>
10 10
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 // Used to dispatch commands from the Wrench menu. The custom items within the 49 // Used to dispatch commands from the Wrench menu. The custom items within the
50 // menu cannot be hooked up directly to First Responder because the window in 50 // menu cannot be hooked up directly to First Responder because the window in
51 // which the controls reside is not the BrowserWindowController, but a 51 // which the controls reside is not the BrowserWindowController, but a
52 // NSCarbonMenuWindow; this screws up the typical |-commandDispatch:| system. 52 // NSCarbonMenuWindow; this screws up the typical |-commandDispatch:| system.
53 - (IBAction)dispatchWrenchMenuCommand:(id)sender; 53 - (IBAction)dispatchWrenchMenuCommand:(id)sender;
54 54
55 // Returns the weak reference to the WrenchMenuModel. 55 // Returns the weak reference to the WrenchMenuModel.
56 - (WrenchMenuModel*)wrenchMenuModel; 56 - (WrenchMenuModel*)wrenchMenuModel;
57 57
58 // Inserts the update available notification menu item.
59 - (void)insertUpdateAvailableItem;
60
61 @end 58 @end
62 59
63 //////////////////////////////////////////////////////////////////////////////// 60 ////////////////////////////////////////////////////////////////////////////////
64 61
65 @interface WrenchMenuController (UnitTesting) 62 @interface WrenchMenuController (UnitTesting)
66 // |-dispatchWrenchMenuCommand:| calls this after it has determined the tag of 63 // |-dispatchWrenchMenuCommand:| calls this after it has determined the tag of
67 // the sender. The default implementation executes the command on the outermost 64 // the sender. The default implementation executes the command on the outermost
68 // run loop using |-performSelector...withDelay:|. This is not desirable in 65 // run loop using |-performSelector...withDelay:|. This is not desirable in
69 // unit tests because it's hard to test around run loops in a deterministic 66 // unit tests because it's hard to test around run loops in a deterministic
70 // manner. To avoid those headaches, tests should provide an alternative 67 // manner. To avoid those headaches, tests should provide an alternative
71 // implementation. 68 // implementation.
72 - (void)dispatchCommandInternal:(NSInteger)tag; 69 - (void)dispatchCommandInternal:(NSInteger)tag;
73 @end 70 @end
74 71
75 #endif // CHROME_BROWSER_COCOA_WRENCH_MENU_CONTROLLER_H_ 72 #endif // CHROME_BROWSER_COCOA_WRENCH_MENU_CONTROLLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/toolbar_controller.mm ('k') | chrome/browser/cocoa/wrench_menu_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698