Mac: fix Text Encoding menu/submenu

Mac: fix Text Encoding menu/submenu

(1) Clicking on the Text Encoding menu item should display the submenu, not try to execute a nonexistent command.
(2) The Text Encoding menu item shouldn't be disabled, but instead the submenu's contents (so that the submenu is always visible). See Apple's HIG:
<http://developer.apple.com/mac/library/DOCUMENTATION/UserExperience/Conceptual/AppleHIGuidelines/XHIGMenus/XHIGMenus.html#//apple_ref/doc/uid/TP30000356-TPXREF122>;.

Changes to MainMenu.xib: disconnected |-commandDispatch:| from the Text Encoding menu item.

BUG=25957, 26593
TEST=Check that the Text Encoding submenu is always available, with its contents disabled on the NTP (for example) and enabled (and working) on a normal web page. Check that clicking (and releasing) on the Text Encoding menu item itself shows the submenu.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30836

[pink (ping after 24hrs), 2009-11-03 18:25:03]

LGTM

[TVL, 2009-11-03 18:26:27]

http://codereview.chromium.org/345050/diff/1/3
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/345050/diff/1/3#newcode586
Line 586: EncodingMenuController encoding_controller;
how expensive is constructing one of these, should we keep one around instead?

[pink (ping after 24hrs), 2009-11-03 18:28:58]

From looking, it's pretty darn cheap. it's mostly just a static table,
the ctor itself does nothing.

On Tue, Nov 3, 2009 at 1:26 PM,  <thomasvl@chromium.org> wrote:
>
> http://codereview.chromium.org/345050/diff/1/3
> File chrome/browser/cocoa/browser_window_controller.mm (right):
>
> http://codereview.chromium.org/345050/diff/1/3#newcode586
> Line 586: EncodingMenuController encoding_controller;
> how expensive is constructing one of these, should we keep one around
> instead?
>
> http://codereview.chromium.org/345050
>



-- 
Mike Pinkerton
Mac Weenie
pinkerton@google.com

[viettrungluu, 2009-11-03 18:52:10]

Really cheap (see what pink said), so I'll take it as being good to go. Thanks.

On 2009/11/03 18:26:27, TVL wrote:
> http://codereview.chromium.org/345050/diff/1/3
> File chrome/browser/cocoa/browser_window_controller.mm (right):
> 
> http://codereview.chromium.org/345050/diff/1/3#newcode586
> Line 586: EncodingMenuController encoding_controller;
> how expensive is constructing one of these, should we keep one around instead?

[TVL, 2009-11-03 18:53:06]

lg