Mac: fix Text Encoding menu/submenu

chrome/browser/cocoa/browser_window_controller.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <Carbon/Carbon.h>
 
 #include "base/mac_util.h"
 #include "base/scoped_nsdisable_screen_updates.h"
 #import "base/scoped_nsobject.h"
 #include "base/sys_string_conversions.h"
@@ skipping 561 matching lines @@
           enable &= [self numberOfTabs] > 1 && [[self window] isKeyWindow];
           break;
         case IDC_RESTORE_TAB:
           // We have to ask the Browser manually if we can restore. The
           // command updater doesn't know.
           enable &= browser_->CanRestoreTab();
           break;
         case IDC_FULLSCREEN:
           enable &= [self supportsFullscreen];
           break;
+        default:
+          // Special handling for the contents of the Text Encoding submenu. On
+          // Mac OS, instead of enabling/disabling the top-level menu item, we
+          // enable/disable the submenu's contents (per Apple's HIG).
+          EncodingMenuController encoding_controller;

[TVL, 2009/11/03 18:26:28]

how expensive is constructing one of these, should we keep one around instead?

+          if (encoding_controller.DoesCommandBelongToEncodingMenu(tag)) {
+            enable &= browser_->command_updater()->IsCommandEnabled(
+                IDC_ENCODING_MENU) ? YES : NO;
+          }
       }
 
       // If the item is toggleable, find its toggle state and
       // try to update it.  This is a little awkward, but the alternative is
       // to check after a commandDispatch, which seems worse.
       [self updateToggleStateWithTag:tag forItem:item];
     }
   }
   return enable;
 }
@@ skipping 942 matching lines @@
   if (frameOverlayInactiveImage) {
     [theme setValue:frameOverlayInactiveImage
        forAttribute:@"overlay"
               style:GTMThemeStyleWindow
               state:GTMThemeStateInactiveWindow];
   }
 
   return theme;
 }
 @end