Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 344030: Handle the fact that MIMETypeRegistry::getMIMETypeForPath returns... (Closed)

Created:
11 years, 1 month ago by abarth-chromium
Modified:
9 years, 7 months ago
Reviewers:
Victor Wang, dglazkov
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Handle the fact that MIMETypeRegistry::getMIMETypeForPath returns application/octet-stream when it can't figure out the MIME type for a path. BUG=26253 TEST=LayoutTests/http/tests/navigation/reload-subframe-object.html

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M webkit/glue/webframeloaderclient_impl.cc View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 10 (0 generated)
abarth-chromium
11 years, 1 month ago (2009-10-30 08:06:03 UTC) #1
Victor Wang
http://codereview.chromium.org/344030/diff/3001/3002 File webkit/glue/webframeloaderclient_impl.cc (right): http://codereview.chromium.org/344030/diff/3001/3002#newcode1288 Line 1288: if (mime_type.isEmpty() || mime_type == "application/octet-stream") what if ...
11 years, 1 month ago (2009-10-30 18:44:28 UTC) #2
dglazkov
Can we get this moving again?
11 years, 1 month ago (2009-11-10 16:21:56 UTC) #3
dglazkov
Can we get this moving again? http://codereview.chromium.org/344030
11 years, 1 month ago (2009-11-10 16:22:15 UTC) #4
dglazkov
Can we get this moving again? http://codereview.chromium.org/344030
11 years, 1 month ago (2009-11-10 16:28:16 UTC) #5
abarth-chromium
Yes. Currently the Sify issue is my top priority, but this is second.
11 years, 1 month ago (2009-11-10 16:54:55 UTC) #6
abarth-chromium
Yes. Currently the Sify issue is my top priority, but this is second. http://codereview.chromium.org/344030
11 years, 1 month ago (2009-11-10 16:55:15 UTC) #7
abarth-chromium
Yes. Currently the Sify issue is my top priority, but this is second. http://codereview.chromium.org/344030
11 years, 1 month ago (2009-11-10 17:01:15 UTC) #8
abarth-chromium
Yes. Currently the Sify issue is my top priority, but this is second. http://codereview.chromium.org/344030
11 years, 1 month ago (2009-11-10 17:11:22 UTC) #9
abarth-chromium
11 years, 1 month ago (2009-11-12 10:57:17 UTC) #10
This moved upstream with the WebKit API:
https://bugs.webkit.org/show_bug.cgi?id=31398.  I'm going to close this code
review.

Powered by Google App Engine
This is Rietveld 408576698