Handle the fact that MIMETypeRegistry::getMIMETypeForPath returns...

webkit/glue/webframeloaderclient_impl.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "Chrome.h"
 #include "CString.h"
 #include "Document.h"
 #include "DocumentLoader.h"
@@ skipping 1265 matching lines @@
   // WebCoreSupport/WebFrameBridge.mm.
 
   String mime_type = explicit_mime_type;
   if (mime_type.isEmpty()) {
     // Try to guess the MIME type based off the extension.
     String filename = url.lastPathComponent();
     int extension_pos = filename.reverseFind('.');
     if (extension_pos >= 0)
       mime_type = MIMETypeRegistry::getMIMETypeForPath(url.path());
 
-    if (mime_type.isEmpty())
+    // MIMETypeRegistry::getMIMETypeForPath returns application/octet-stream
+    // when it can't find a MIME type for the path.
+    if (mime_type.isEmpty() || mime_type == "application/octet-stream")

[Victor Wang, 2009/10/30 18:44:28]

what if the path is a binary file. getMIMETypeForPath returns
"application/octet-stream" if it is a binary file or file extension is not
recognized. The old code just sets ObjectContentFrame if the extension is not
recognized. This patch changes the behavior, should we return ObjectContentFrame
if the path points to a binary file?

       return ObjectContentFrame;
   }
 
   if (MIMETypeRegistry::isSupportedImageMIMEType(mime_type))
     return ObjectContentImage;
 
   // If Chrome is started with the --disable-plugins switch, pluginData is null.
   PluginData* plugin_data = webframe_->frame()->page()->pluginData();
   if (plugin_data && plugin_data->supportsMimeType(mime_type))
     return ObjectContentNetscapePlugin;
@@ skipping 33 matching lines @@
   WebViewImpl* webview = webframe_->GetWebViewImpl();
   if (webview->client())
     webview->client()->navigateBackForwardSoon(offset);
 }
 
 PassOwnPtr<WebPluginLoadObserver> WebFrameLoaderClient::GetPluginLoadObserver() {
   WebDataSourceImpl* ds = WebDataSourceImpl::fromDocumentLoader(
       webframe_->frame()->loader()->activeDocumentLoader());
   return ds->releasePluginLoadObserver();
 }