Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issue 3432022: Clean up some messiness in Scopes. (Closed)

Created:
10 years, 3 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Clean up some messiness in Scopes. For some reason, the scope's arguments and arguments shadow were variable proxies, which resulted in all references to the arguments shadow being shared in the AST. This makes it hard to put per-node state on the AST nodes. I took the opportunity to remove Variable::AsVariable which has confused people in the past, and to rename Variable::slot to the more accurate Variable::AsSlot. Committed: http://code.google.com/p/v8/source/detail?r=5517

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -211 lines) Patch
M src/arm/codegen-arm.cc View 19 chunks +31 lines, -31 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 13 chunks +19 lines, -20 lines 0 comments Download
M src/ast.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/ast.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/codegen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/data-flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 21 chunks +31 lines, -31 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 13 chunks +19 lines, -20 lines 0 comments Download
M src/ia32/virtual-frame-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/rewriter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/scopeinfo.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/scopes.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/scopes.cc View 6 chunks +18 lines, -19 lines 0 comments Download
M src/variables.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/variables.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M src/x64/codegen-x64.cc View 21 chunks +31 lines, -31 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 13 chunks +19 lines, -20 lines 0 comments Download
M src/x64/virtual-frame-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
I did not try to clean up the whole VariableProxy::AsVariable mess because it touches too ...
10 years, 3 months ago (2010-09-23 14:18:17 UTC) #1
fschneider
10 years, 3 months ago (2010-09-23 14:31:04 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698