Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 341087: Eliminate QueryOptions::most_recent_visit_only. All non-unittest consumers o... (Closed)

Created:
11 years, 1 month ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Eliminate QueryOptions::most_recent_visit_only. All non-unittest consumers of this set it to true, so just turn it on unconditionally. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -99 lines) Patch
M chrome/browser/autocomplete/history_contents_provider.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/dom_ui/history_ui.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_history_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/expire_history_backend_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_querying_unittest.cc View 4 chunks +3 lines, -31 lines 0 comments Download
M chrome/browser/history/history_types.h View 3 chunks +6 lines, -16 lines 0 comments Download
M chrome/browser/history/text_database.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/history/text_database.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/history/visit_database.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/history/visit_database.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/history/visit_database_unittest.cc View 1 chunk +8 lines, -17 lines 0 comments Download
M chrome/browser/possible_url_model.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
11 years, 1 month ago (2009-11-03 19:38:58 UTC) #1
brettw
11 years, 1 month ago (2009-11-03 22:49:58 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698