Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4109)

Unified Diff: chrome/browser/history/history_types.h

Issue 341087: Eliminate QueryOptions::most_recent_visit_only. All non-unittest consumers o... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_querying_unittest.cc ('k') | chrome/browser/history/text_database.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_types.h
===================================================================
--- chrome/browser/history/history_types.h (revision 30836)
+++ chrome/browser/history/history_types.h (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -467,17 +467,15 @@
// QueryOptions ----------------------------------------------------------------
struct QueryOptions {
- QueryOptions()
- : most_recent_visit_only(false),
- max_count(0) {
- }
+ QueryOptions() : max_count(0) {}
// The time range to search for matches in.
//
- // For text search queries, this will match only the most recent visit of the
- // URL. If the URL was visited in the given time period, but has also been
+ // This will match only the one recent visit of a URL. For text search
+ // queries, if the URL was visited in the given time period, but has also been
// visited more recently than that, it will not be returned. When the text
- // query is empty, this will return all URLs visited in the time range.
+ // query is empty, this will return the most recent visit within the time
+ // range.
//
// As a special case, if both times are is_null(), then the entire database
// will be searched. However, if you set one, you must set the other.
@@ -492,14 +490,6 @@
begin_time = end_time - base::TimeDelta::FromDays(days_ago);
}
- // When set, only one visit for each URL will be returned, which will be the
- // most recent one in the result set. When false, each URL may have multiple
- // visit entries corresponding to each time the URL was visited in the given
- // time range.
- //
- // Defaults to false (all visits).
- bool most_recent_visit_only;
-
// The maximum number of results to return. The results will be sorted with
// the most recent first, so older results may not be returned if there is not
// enough room. When 0, this will return everything (the default).
« no previous file with comments | « chrome/browser/history/history_querying_unittest.cc ('k') | chrome/browser/history/text_database.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698