Eliminate QueryOptions::most_recent_visit_only. All non-unittest consumers o...

chrome/browser/dom_ui/history_ui.cc

-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/dom_ui/history_ui.h"
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/i18n/time_formatting.h"
 #include "base/message_loop.h"
 #include "base/singleton.h"
@@ skipping 129 matching lines @@
   int day = 0;
   ExtractIntegerValue(value, &day);
 
   // Set our query options.
   history::QueryOptions options;
   options.begin_time = base::Time::Now().LocalMidnight();
   options.begin_time -= base::TimeDelta::FromDays(day);
   options.end_time = base::Time::Now().LocalMidnight();
   options.end_time -= base::TimeDelta::FromDays(day - 1);
 
-  // As we're querying per-day, we can turn entry repeats off.
-  options.most_recent_visit_only = true;
-
   // Need to remember the query string for our results.
   search_text_ = std::wstring();
 
   HistoryService* hs =
       dom_ui_->GetProfile()->GetHistoryService(Profile::EXPLICIT_ACCESS);
   hs->QueryHistory(search_text_,
       options,
       &cancelable_consumer_,
       NewCallback(this, &BrowsingHistoryHandler::QueryComplete));
 }
 
 void BrowsingHistoryHandler::HandleSearchHistory(const Value* value) {
   // Anything in-flight is invalid.
   cancelable_consumer_.CancelAllRequests();
 
   // Get arguments (if any).
   int month = 0;
   std::wstring query;
   ExtractSearchHistoryArguments(value, &month, &query);
 
   // Set the query ranges for the given month.
   history::QueryOptions options = CreateMonthQueryOptions(month);
 
-  // When searching, limit the number of results returned and only show the
-  // most recent matches.
+  // When searching, limit the number of results returned.
   options.max_count = kMaxSearchResults;
-  options.most_recent_visit_only = true;
 
   // Need to remember the query string for our results.
   search_text_ = query;
   HistoryService* hs =
       dom_ui_->GetProfile()->GetHistoryService(Profile::EXPLICIT_ACCESS);
   hs->QueryHistory(search_text_,
       options,
       &cancelable_consumer_,
       NewCallback(this, &BrowsingHistoryHandler::QueryComplete));
 }
@@ skipping 192 matching lines @@
 const GURL HistoryUI::GetHistoryURLWithSearchText(const std::wstring& text) {
   return GURL(std::string(chrome::kChromeUIHistoryURL) + "#q=" +
               EscapeQueryParamValue(WideToUTF8(text)));
 }
 
 // static
 RefCountedMemory* HistoryUI::GetFaviconResourceBytes() {
   return ResourceBundle::GetSharedInstance().
       LoadImageResourceBytes(IDR_HISTORY_FAVICON);
 }