Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 339045: Rename the kinds of locations to be consistent with the (codegen)... (Closed)

Created:
11 years, 1 month ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Rename the kinds of locations to be consistent with the (codegen) context of the expressions they label. Introduce an "unintialized" location to catch failure to assign any location at all. Changed the object literal initialization on ARM to use a Store IC in the same cases where it did on the other platforms. This was required because the location of the literal property name is given an "unitialized" location.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -201 lines) Patch
M src/arm/fast-codegen-arm.cc View 17 chunks +92 lines, -63 lines 0 comments Download
M src/ast.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/fast-codegen.cc View 3 chunks +15 lines, -8 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 19 chunks +76 lines, -59 lines 0 comments Download
M src/location.h View 1 chunk +6 lines, -5 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 20 chunks +77 lines, -60 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
We should decide what location we want to assign to the literals that we don't ...
11 years, 1 month ago (2009-10-28 15:22:13 UTC) #1
William Hesse
LGTM.
11 years, 1 month ago (2009-10-28 15:28:53 UTC) #2
fschneider
11 years, 1 month ago (2009-10-28 16:46:39 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698