Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: src/location.h

Issue 339045: Rename the kinds of locations to be consistent with the (codegen)... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/fast-codegen-ia32.cc ('k') | src/x64/fast-codegen-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/location.h
===================================================================
--- src/location.h (revision 3167)
+++ src/location.h (working copy)
@@ -35,13 +35,14 @@
class Location BASE_EMBEDDED {
public:
- enum Type { NOWHERE, TEMP };
+ enum Type { UNINITIALIZED, EFFECT, VALUE };
- static Location Temporary() { return Location(TEMP); }
- static Location Nowhere() { return Location(NOWHERE); }
+ static Location Uninitialized() { return Location(UNINITIALIZED); }
+ static Location Effect() { return Location(EFFECT); }
+ static Location Value() { return Location(VALUE); }
- bool is_temporary() { return type_ == TEMP; }
- bool is_nowhere() { return type_ == NOWHERE; }
+ bool is_effect() { return type_ == EFFECT; }
+ bool is_value() { return type_ == VALUE; }
Type type() { return type_; }
« no previous file with comments | « src/ia32/fast-codegen-ia32.cc ('k') | src/x64/fast-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698