Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: src/fast-codegen.cc

Issue 339045: Rename the kinds of locations to be consistent with the (codegen)... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler.cc ('k') | src/ia32/fast-codegen-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/fast-codegen.cc
===================================================================
--- src/fast-codegen.cc (revision 3167)
+++ src/fast-codegen.cc (working copy)
@@ -73,14 +73,18 @@
void FastCodeGenerator::Move(Location destination, Location source) {
switch (destination.type()) {
- case Location::NOWHERE:
+ case Location::UNINITIALIZED:
+ UNREACHABLE();
+
+ case Location::EFFECT:
break;
- case Location::TEMP:
+ case Location::VALUE:
switch (source.type()) {
- case Location::NOWHERE:
+ case Location::UNINITIALIZED: // Fall through.
+ case Location::EFFECT:
UNREACHABLE();
- case Location::TEMP:
+ case Location::VALUE:
break;
}
break;
@@ -92,9 +96,11 @@
// function.
void FastCodeGenerator::Move(Location destination, Register source) {
switch (destination.type()) {
- case Location::NOWHERE:
+ case Location::UNINITIALIZED:
+ UNREACHABLE();
+ case Location::EFFECT:
break;
- case Location::TEMP:
+ case Location::VALUE:
masm_->push(source);
break;
}
@@ -105,9 +111,10 @@
// function.
void FastCodeGenerator::Move(Register destination, Location source) {
switch (source.type()) {
- case Location::NOWHERE:
+ case Location::UNINITIALIZED: // Fall through.
+ case Location::EFFECT:
UNREACHABLE();
- case Location::TEMP:
+ case Location::VALUE:
masm_->pop(destination);
}
}
« no previous file with comments | « src/compiler.cc ('k') | src/ia32/fast-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698