Issue 3389012: Revert 59641 - Add the onBeforeNavigate and onErrorOccured events to the webN...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3389012: Revert 59641 - Add the onBeforeNavigate and onErrorOccured events to the webN... (Closed)

Created:
10 years, 3 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 59641 - Add the onBeforeNavigate and onErrorOccured events to the webNavigation API. Also, rewrite the onCommitted event such that AUTO_SUBFRAME events are also registered. The frameId and the requestId fields are still unimplemented. Also, there occur navigation events after an error is reported. BUG=50943 TEST=WebNavigationEvents Review URL: http://codereview.chromium.org/3436002 TBR=jochen@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59642

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -336 lines)			Patch
M	chrome/browser/extensions/extension_webnavigation_api.h	View	2 chunks	+6 lines, -21 lines	0 comments	Download
M	chrome/browser/extensions/extension_webnavigation_api.cc	View	4 chunks	+13 lines, -71 lines	0 comments	Download
M	chrome/browser/tab_contents/provisional_load_details.h	View	3 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/tab_contents/provisional_load_details.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	chrome/common/notification_type.h	View	1 chunk	+2 lines, -9 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/navigation/test.html	View	1 chunk	+78 lines, -201 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages