chrome/common/notification_type.h - Issue 3389012: Revert 59641 - Add the onBeforeNavigate and onErrorOccured events to the webN...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/notification_type.h

Issue 3389012: Revert 59641 - Add the onBeforeNavigate and onErrorOccured events to the webN... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/tab_contents/tab_contents.cc ('k') | chrome/test/data/extensions/api_test/webnavigation/navigation/test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/notification_type.h

===================================================================

--- chrome/common/notification_type.h (revision 59641)

+++ chrome/common/notification_type.h (working copy)

@@ -103,17 +103,10 @@

// A frame is staring a provisional load. The source is a

// Source<NavigationController> corresponding to the tab in which the load

- // occurs. Details is a ProvisionalLoadDetails object.

+ // occurs. Details is a bool specifying if the load occurs in the main

+ // frame (or a sub-frame if false).

FRAME_PROVISIONAL_LOAD_START,

- // The provisional load for a frame was committed. The source is a

- // NavigationController corresponding to the tab in which the load occured.

- // Details is a ProvisionalLoadDetails object. In contrast to

- // NAV_ENTRY_COMMITTED, this notification is sent when the load was

- // committed, even if no navigation entry was committed (such as

- // AUTO_SUBFRAME navigations).

- FRAME_PROVISIONAL_LOAD_COMMITTED,

// Content was loaded from an in-memory cache. The source will be a

// Source<NavigationController> corresponding to the tab in which the load

// occurred. Details in the form of a LoadFromMemoryCacheDetails object