chrome/browser/tab_contents/provisional_load_details.h - Issue 3389012: Revert 59641 - Add the onBeforeNavigate and onErrorOccured events to the webN...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/provisional_load_details.h

Issue 3389012: Revert 59641 - Add the onBeforeNavigate and onErrorOccured events to the webN... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_webnavigation_api.cc ('k') | chrome/browser/tab_contents/provisional_load_details.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/provisional_load_details.h

===================================================================

--- chrome/browser/tab_contents/provisional_load_details.h (revision 59641)

+++ chrome/browser/tab_contents/provisional_load_details.h (working copy)

@@ -9,7 +9,6 @@

#include <string>

#include "base/basictypes.h"

-#include "chrome/common/page_transition_types.h"

#include "googleurl/src/gurl.h"

// This class captures some of the information associated to the provisional

@@ -33,13 +32,6 @@

void set_error_code(int error_code) { error_code_ = error_code; }

int error_code() const { return error_code_; }

- void set_transition_type(PageTransition::Type transition_type) {

- transition_type_ = transition_type;

- }

- PageTransition::Type transition_type() const {

- return transition_type_;

- }

const GURL& url() const { return url_; }

bool main_frame() const { return is_main_frame_; }

@@ -58,7 +50,6 @@

private:

int error_code_;

- PageTransition::Type transition_type_;

GURL url_;

bool is_main_frame_;

bool is_in_page_navigation_;