Issue 338031: linux: fix icudt42l_dat.s on arm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338031: linux: fix icudt42l_dat.s on arm (Closed)

Created:
11 years, 1 month ago by piman

Modified:
9 years, 7 months ago

Reviewers:
jungshik at Google, Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/deps/third_party/icu42/

Visibility:
Public.

Description

linux: fix icudt42l_dat.s on arm Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30145

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	linux/icudt42l_dat.s	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

piman

Fixed build regression on arm. jshin: what tool is used to generate that assembly file, ...

11 years, 1 month ago (2009-10-27 00:43:42 UTC) #1

Evan Martin

I have no idea what this does, but if you're sure it's correct it gets ...

11 years, 1 month ago (2009-10-27 00:45:46 UTC) #2

piman

On Mon, Oct 26, 2009 at 5:45 PM, <evan@chromium.org> wrote: > I have no idea ...

11 years, 1 month ago (2009-10-27 01:01:08 UTC) #3

Evan Martin

11 years, 1 month ago (2009-10-27 01:02:19 UTC) #4

On 2009/10/27 01:01:08, piman wrote:
> You checked in an exact same change for Joel previously (
> http://codereview.chromium.org/215026 )

Ah, his change description was more helpful.  :)

Expand Messages | Collapse Messages