Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 215026: Make ICU assembly portable to ARM (Closed)

Created:
11 years, 3 months ago by Joel Stanley (old)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make ICU assembly portable to ARM This patch fixes the following error: CC src/out/Release/obj/third_party/icu/linux/icudt42l_dat.o third_party/icu/linux/icudt42l_dat.s: Assembler messages: third_party/icu/linux/icudt42l_dat.s:5: Error: unrecognized symbol type "" make: *** [src/out/Release/obj/third_party/icu/linux/icudt42l_dat.o] Error 1 The problem is the assembly syntax that is used is not portable to ARM, where the '@' symbol is a comment: > Note on targets where the @ character is the start of a comment > (eg ARM) then another character is used instead. For example the > ARM port uses the % character. (from http://sourceware.org/binutils/docs-2.18/as/Section.html#Section) Using % instead of @ appears to work on both ARM and x64. BUG=22369 Patch by Joel Stanley <joel@jms.id.au>; Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26784

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M linux/icudt42l_dat.s View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Joel Stanley (old)
11 years, 3 months ago (2009-09-22 01:22:31 UTC) #1
Evan Martin
11 years, 3 months ago (2009-09-22 01:33:02 UTC) #2
LGTM, committing

Powered by Google App Engine
This is Rietveld 408576698