Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3361003: Revert 58215 - Revert 58186 - Move the keyboard files from base/ to app/.... (Closed)

Created:
10 years, 3 months ago by bryeung
Modified:
9 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, dpranke+watch_chromium.org, nkostylev+cc_chromium.org, Alpha Left Google, Sergey Ulanov, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, dmac, pam+watch_chromium.org, awong, garykac, Paweł Hajdan Jr., darin-cc_chromium.org, ben+cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 58215 - Revert 58186 - Move the keyboard files from base/ to app/. Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org TBR=phajdan.jr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1003 lines, -2871 lines) Patch
M app/app_base.gypi View 5 chunks +34 lines, -0 lines 0 comments Download
A + app/event_synthesis_gtk.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + app/event_synthesis_gtk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + app/keyboard_code_conversion.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + app/keyboard_code_conversion.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + app/keyboard_code_conversion_gtk.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + app/keyboard_code_conversion_gtk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + app/keyboard_code_conversion_mac.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + app/keyboard_code_conversion_mac.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + app/keyboard_code_conversion_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + app/keyboard_code_conversion_win.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + app/keyboard_code_conversion_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + app/keyboard_codes.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + app/keyboard_codes_posix.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + app/keyboard_codes_win.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/menus/accelerator.h View 4 chunks +5 lines, -5 lines 0 comments Download
M app/menus/accelerator_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M app/menus/accelerator_gtk.h View 3 chunks +5 lines, -5 lines 0 comments Download
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D base/event_synthesis_gtk.h View 1 chunk +0 lines, -37 lines 0 comments Download
D base/event_synthesis_gtk.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D base/keyboard_code_conversion.h View 1 chunk +0 lines, -22 lines 0 comments Download
D base/keyboard_code_conversion.cc View 1 chunk +0 lines, -296 lines 0 comments Download
D base/keyboard_code_conversion_gtk.h View 1 chunk +0 lines, -50 lines 0 comments Download
D base/keyboard_code_conversion_gtk.cc View 1 chunk +0 lines, -617 lines 0 comments Download
D base/keyboard_code_conversion_mac.h View 1 chunk +0 lines, -34 lines 0 comments Download
D base/keyboard_code_conversion_mac.mm View 1 chunk +0 lines, -293 lines 0 comments Download
D base/keyboard_code_conversion_unittest.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D base/keyboard_codes.h View 1 chunk +0 lines, -17 lines 0 comments Download
D base/keyboard_codes_posix.h View 1 chunk +0 lines, -210 lines 0 comments Download
D base/keyboard_codes_win.h View 1 chunk +0 lines, -186 lines 0 comments Download
M base/win_util.h View 2 chunks +0 lines, -5 lines 0 comments Download
M base/win_util.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc View 17 chunks +27 lines, -27 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/ui_controls.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/automation/ui_controls_linux.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/automation/ui_controls_mac.mm View 8 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/automation/ui_controls_win.cc View 8 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 31 chunks +45 lines, -45 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/new_user_view.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/password_changed_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screen_lock_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/update_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/user_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_accessibility_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/cocoa/html_dialog_window_controller.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_input_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/find_bar_host_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/accelerator_table_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/accelerator_table_gtk.cc View 2 chunks +94 lines, -94 lines 0 comments Download
M chrome/browser/views/accessible_toolbar_view.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view_test.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/views/bookmark_bubble_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/browser_keyboard_accessibility_test_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/views/dropdown_bar_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/extensions/extension_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/find_bar_host.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/views/find_bar_host_interactive_uitest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/views/find_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/views/fullscreen_exit_bubble.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/html_dialog_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/info_bubble.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/jsmessage_box_dialog.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/keyword_editor_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/location_bar/location_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/location_bar/page_action_image_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/location_bar/star_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/options/cookies_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/cookies_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/views/tab_contents/render_view_context_menu_views.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/views/task_manager_view.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/views/toolbar_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/views/unhandled_keyboard_event_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/url_picker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/password_autocomplete_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/password_autocomplete_manager_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/render_view_browsertest.cc View 3 chunks +25 lines, -25 lines 0 comments Download
M chrome/test/automated_ui_tests/automated_ui_tests.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/automated_ui_tests/automated_ui_tests.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/test/automation/automation_messages_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/window_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/automation/window_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/interactive_ui/keyboard_access_uitest.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/test/interactive_ui/npapi_interactive_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/reliability/page_load_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/render_view_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/ui_test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/ui_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/keymap.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/webdriver/keymap.cc View 1 chunk +89 lines, -89 lines 0 comments Download
M remoting/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/event_executor_win.cc View 2 chunks +167 lines, -167 lines 0 comments Download
M views/accelerator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M views/accelerator.cc View 1 chunk +14 lines, -14 lines 0 comments Download
M views/controls/button/custom_button.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M views/controls/button/menu_button.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M views/controls/button/native_button.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M views/controls/combobox/combobox.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/link.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M views/controls/menu/menu_controller.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M views/controls/menu/menu_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/menu/native_menu_gtk.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M views/controls/menu/native_menu_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/native_control.h View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/native_control.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M views/controls/scrollbar/bitmap_scroll_bar.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M views/controls/scrollbar/native_scroll_bar_gtk.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M views/controls/scrollbar/native_scroll_bar_win.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M views/controls/tabbed_pane/tabbed_pane.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M views/controls/table/group_table_view.h View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/table/group_table_view.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M views/controls/table/native_table_win.h View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/table/native_table_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/table/table_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/table/table_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/table/table_view_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/textfield/native_textfield_win.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M views/controls/textfield/textfield.h View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/textfield/textfield.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M views/controls/tree/tree_view.h View 3 chunks +3 lines, -3 lines 0 comments Download
M views/controls/tree/tree_view.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M views/event.h View 4 chunks +5 lines, -5 lines 0 comments Download
M views/event.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/event_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/examples/table2_example.h View 1 chunk +1 line, -1 line 0 comments Download
M views/examples/table_example.h View 1 chunk +1 line, -1 line 0 comments Download
M views/focus/accelerator_handler_gtk_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M views/focus/accelerator_handler_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M views/focus/focus_manager.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M views/focus/focus_manager_unittest.cc View 9 chunks +45 lines, -45 lines 0 comments Download
M views/view_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M views/widget/root_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M views/widget/widget_gtk.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M views/widget/widget_win.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M views/window/dialog_client_view.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M views/window/window_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/support/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/support/webkit_support.h View 2 chunks +14 lines, -14 lines 0 comments Download
M webkit/tools/test_shell/event_sending_controller.cc View 4 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bryeung
10 years, 3 months ago (2010-09-02 19:21:12 UTC) #1
Paweł Hajdan Jr.
10 years, 3 months ago (2010-09-02 19:30:37 UTC) #2 
OK

Powered by Google App Engine
This is Rietveld 408576698