views/controls/button/menu_button.cc - Issue 3361003: Revert 58215 - Revert 58186 - Move the keyboard files from base/ to app/....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/controls/button/menu_button.cc

Issue 3361003: Revert 58215 - Revert 58186 - Move the keyboard files from base/ to app/.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: views/controls/button/menu_button.cc

===================================================================

--- views/controls/button/menu_button.cc (revision 58386)

+++ views/controls/button/menu_button.cc (working copy)

@@ -219,10 +219,10 @@

}

bool MenuButton::OnKeyPressed(const KeyEvent& e) {

- if (e.GetKeyCode() == base::VKEY_SPACE ||

- e.GetKeyCode() == base::VKEY_RETURN ||

- e.GetKeyCode() == base::VKEY_UP ||

- e.GetKeyCode() == base::VKEY_DOWN) {

+ if (e.GetKeyCode() == app::VKEY_SPACE ||

+ e.GetKeyCode() == app::VKEY_RETURN ||

+ e.GetKeyCode() == app::VKEY_UP ||

+ e.GetKeyCode() == app::VKEY_DOWN) {

bool result = Activate();

if (GetFocusManager()->GetFocusedView() == NULL)

RequestFocus();

« no previous file with comments | « views/controls/button/custom_button.cc ('k') | views/controls/button/native_button.cc » ('j') | no next file with comments »