Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: chrome/browser/views/accessible_toolbar_view.cc

Issue 3361003: Revert 58215 - Revert 58186 - Move the keyboard files from base/ to app/.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/logging.h" 5 #include "base/logging.h"
6 #include "chrome/browser/view_ids.h" 6 #include "chrome/browser/view_ids.h"
7 #include "chrome/browser/views/frame/browser_view.h" 7 #include "chrome/browser/views/frame/browser_view.h"
8 #include "chrome/browser/views/location_bar/location_bar_view.h" 8 #include "chrome/browser/views/location_bar/location_bar_view.h"
9 #include "chrome/browser/views/accessible_toolbar_view.h" 9 #include "chrome/browser/views/accessible_toolbar_view.h"
10 #include "views/controls/button/menu_button.h" 10 #include "views/controls/button/menu_button.h"
11 #include "views/controls/native/native_view_host.h" 11 #include "views/controls/native/native_view_host.h"
12 #include "views/focus/focus_search.h" 12 #include "views/focus/focus_search.h"
13 #include "views/focus/view_storage.h" 13 #include "views/focus/view_storage.h"
14 #include "views/widget/tooltip_manager.h" 14 #include "views/widget/tooltip_manager.h"
15 #include "views/widget/widget.h" 15 #include "views/widget/widget.h"
16 16
17 AccessibleToolbarView::AccessibleToolbarView() 17 AccessibleToolbarView::AccessibleToolbarView()
18 : toolbar_has_focus_(false), 18 : toolbar_has_focus_(false),
19 ALLOW_THIS_IN_INITIALIZER_LIST(method_factory_(this)), 19 ALLOW_THIS_IN_INITIALIZER_LIST(method_factory_(this)),
20 focus_manager_(NULL), 20 focus_manager_(NULL),
21 home_key_(base::VKEY_HOME, false, false, false), 21 home_key_(app::VKEY_HOME, false, false, false),
22 end_key_(base::VKEY_END, false, false, false), 22 end_key_(app::VKEY_END, false, false, false),
23 escape_key_(base::VKEY_ESCAPE, false, false, false), 23 escape_key_(app::VKEY_ESCAPE, false, false, false),
24 left_key_(base::VKEY_LEFT, false, false, false), 24 left_key_(app::VKEY_LEFT, false, false, false),
25 right_key_(base::VKEY_RIGHT, false, false, false), 25 right_key_(app::VKEY_RIGHT, false, false, false),
26 last_focused_view_storage_id_(-1) { 26 last_focused_view_storage_id_(-1) {
27 focus_search_.reset(new views::FocusSearch(this, true, true)); 27 focus_search_.reset(new views::FocusSearch(this, true, true));
28 } 28 }
29 29
30 AccessibleToolbarView::~AccessibleToolbarView() { 30 AccessibleToolbarView::~AccessibleToolbarView() {
31 if (toolbar_has_focus_) { 31 if (toolbar_has_focus_) {
32 focus_manager_->RemoveFocusChangeListener(this); 32 focus_manager_->RemoveFocusChangeListener(this);
33 } 33 }
34 } 34 }
35 35
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 return NULL; 141 return NULL;
142 } 142 }
143 143
144 bool AccessibleToolbarView::AcceleratorPressed( 144 bool AccessibleToolbarView::AcceleratorPressed(
145 const views::Accelerator& accelerator) { 145 const views::Accelerator& accelerator) {
146 // Special case: don't handle arrows for certain views, like the 146 // Special case: don't handle arrows for certain views, like the
147 // location bar's edit text view, which need them for text editing. 147 // location bar's edit text view, which need them for text editing.
148 views::View* focused_view = focus_manager_->GetFocusedView(); 148 views::View* focused_view = focus_manager_->GetFocusedView();
149 if ((focused_view->GetClassName() == LocationBarView::kViewClassName || 149 if ((focused_view->GetClassName() == LocationBarView::kViewClassName ||
150 focused_view->GetClassName() == views::NativeViewHost::kViewClassName) && 150 focused_view->GetClassName() == views::NativeViewHost::kViewClassName) &&
151 (accelerator.GetKeyCode() == base::VKEY_LEFT || 151 (accelerator.GetKeyCode() == app::VKEY_LEFT ||
152 accelerator.GetKeyCode() == base::VKEY_RIGHT)) { 152 accelerator.GetKeyCode() == app::VKEY_RIGHT)) {
153 return false; 153 return false;
154 } 154 }
155 155
156 switch (accelerator.GetKeyCode()) { 156 switch (accelerator.GetKeyCode()) {
157 case base::VKEY_ESCAPE: 157 case app::VKEY_ESCAPE:
158 RemoveToolbarFocus(); 158 RemoveToolbarFocus();
159 RestoreLastFocusedView(); 159 RestoreLastFocusedView();
160 return true; 160 return true;
161 case base::VKEY_LEFT: 161 case app::VKEY_LEFT:
162 focus_manager_->AdvanceFocus(true); 162 focus_manager_->AdvanceFocus(true);
163 return true; 163 return true;
164 case base::VKEY_RIGHT: 164 case app::VKEY_RIGHT:
165 focus_manager_->AdvanceFocus(false); 165 focus_manager_->AdvanceFocus(false);
166 return true; 166 return true;
167 case base::VKEY_HOME: 167 case app::VKEY_HOME:
168 focus_manager_->SetFocusedViewWithReason( 168 focus_manager_->SetFocusedViewWithReason(
169 GetFirstFocusableChild(), views::FocusManager::kReasonFocusTraversal); 169 GetFirstFocusableChild(), views::FocusManager::kReasonFocusTraversal);
170 return true; 170 return true;
171 case base::VKEY_END: 171 case app::VKEY_END:
172 focus_manager_->SetFocusedViewWithReason( 172 focus_manager_->SetFocusedViewWithReason(
173 GetLastFocusableChild(), views::FocusManager::kReasonFocusTraversal); 173 GetLastFocusableChild(), views::FocusManager::kReasonFocusTraversal);
174 return true; 174 return true;
175 default: 175 default:
176 return false; 176 return false;
177 } 177 }
178 } 178 }
179 179
180 void AccessibleToolbarView::SetVisible(bool flag) { 180 void AccessibleToolbarView::SetVisible(bool flag) {
181 if (IsVisible() && !flag && toolbar_has_focus_) { 181 if (IsVisible() && !flag && toolbar_has_focus_) {
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 228
229 views::FocusTraversable* AccessibleToolbarView::GetFocusTraversableParent() { 229 views::FocusTraversable* AccessibleToolbarView::GetFocusTraversableParent() {
230 DCHECK(toolbar_has_focus_); 230 DCHECK(toolbar_has_focus_);
231 return NULL; 231 return NULL;
232 } 232 }
233 233
234 views::View* AccessibleToolbarView::GetFocusTraversableParentView() { 234 views::View* AccessibleToolbarView::GetFocusTraversableParentView() {
235 DCHECK(toolbar_has_focus_); 235 DCHECK(toolbar_has_focus_);
236 return NULL; 236 return NULL;
237 } 237 }
OLDNEW
« no previous file with comments | « chrome/browser/views/accelerator_table_gtk.cc ('k') | chrome/browser/views/bookmark_bar_view_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698