Issue 3340005: Make NTP look good with themes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3340005: Make NTP look good with themes. (Closed)

Created:
10 years, 3 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
arv (Not doing code reviews), Peter Kasting

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Visibility:
Public.

Description

Make NTP look good with themes. BUG=52913 TEST=Visual inspection. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58272

Patch Set 1 #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+120 lines, -93 lines)			Patch
M	chrome/browser/dom_ui/ntp_resource_cache.cc	View	1 chunk	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.css	View	3 chunks	+47 lines, -28 lines	1 comment	Download
M	chrome/browser/resources/new_new_tab.html	View	2 chunks	+23 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/new_tab_theme.css	View	4 chunks	+25 lines, -38 lines	0 comments	Download
M	chrome/browser/themes/browser_theme_provider.cc	View	4 chunks	+20 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

Screen caps here: http://youngpup.net/z_dropbox/nnntp/8.png http://youngpup.net/z_dropbox/nnntp/9.png

10 years, 3 months ago (2010-09-01 20:45:45 UTC) #1

Peter Kasting

If you happen to be able to also fix crbug.com/51853 , that would be awesome!

10 years, 3 months ago (2010-09-01 20:49:34 UTC) #2

arv (Not doing code reviews)

10 years, 3 months ago (2010-09-01 20:55:42 UTC) #3

LGTM

http://codereview.chromium.org/3340005/diff/1/3
File chrome/browser/resources/new_new_tab.css (right):

http://codereview.chromium.org/3340005/diff/1/3#newcode36
chrome/browser/resources/new_new_tab.css:36: top: 0px;
Don't use units for 0

Expand Messages | Collapse Messages