Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2245)

Unified Diff: chrome/browser/themes/browser_theme_provider.cc

Issue 3340005: Make NTP look good with themes. (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/themes/browser_theme_provider.cc
diff --git a/chrome/browser/themes/browser_theme_provider.cc b/chrome/browser/themes/browser_theme_provider.cc
index 04075a806f50d4c4f8f39eea6d6e66c6ced21515..7283a7198ab0e8d65d63f4bf4beef8fbb95be3de 100644
--- a/chrome/browser/themes/browser_theme_provider.cc
+++ b/chrome/browser/themes/browser_theme_provider.cc
@@ -43,6 +43,13 @@ SkColor TintForUnderline(SkColor input) {
return SkColorSetA(input, SkColorGetA(input) / 3);
}
+SkColor IncreaseLightness(SkColor color, double percent) {
+ color_utils::HSL result;
+ color_utils::SkColorToHSL(color, &result);
+ result.l += (1 - result.l) * percent;
+ return color_utils::HSLToSkColor(result, SkColorGetA(color));
+}
+
// Default colors.
const SkColor kDefaultColorFrame = SkColorSetRGB(66, 116, 201);
const SkColor kDefaultColorFrameInactive = SkColorSetRGB(161, 182, 228);
@@ -79,10 +86,6 @@ const SkColor kDefaultColorNTPHeader = SkColorSetRGB(75, 140, 220);
const SkColor kDefaultColorNTPSection = SkColorSetRGB(229, 239, 254);
const SkColor kDefaultColorNTPSectionText = SK_ColorBLACK;
const SkColor kDefaultColorNTPSectionLink = SkColorSetRGB(6, 55, 116);
-const SkColor kDefaultColorNTPSectionHeaderText = SkColorSetRGB(76, 76, 76);
-const SkColor kDefaultColorNTPSectionHeaderRule = SkColorSetRGB(179, 179, 179);
-const SkColor kDefaultColorNTPSectionHeaderRuleLight =
- SkColorSetRGB(220, 220, 220);
const SkColor kDefaultColorControlBackground = SkColorSetARGB(0, 0, 0, 0);
const SkColor kDefaultColorButtonBackground = SkColorSetARGB(0, 0, 0, 0);
#if defined(OS_MACOSX)
@@ -224,6 +227,19 @@ SkColor BrowserThemeProvider::GetColor(int id) const {
if (theme_pack_.get() && theme_pack_->GetColor(id, &color))
return color;
+ // For backward compat with older themes, some newer colors are generated from
+ // older ones if they are missing.
+ switch (id) {
+ case COLOR_NTP_SECTION_HEADER_TEXT:
+ return IncreaseLightness(GetColor(COLOR_NTP_TEXT), 0.30);
+ case COLOR_NTP_SECTION_HEADER_TEXT_HOVER:
+ return GetColor(COLOR_NTP_TEXT);
+ case COLOR_NTP_SECTION_HEADER_RULE:
+ return IncreaseLightness(GetColor(COLOR_NTP_TEXT), 0.70);
+ case COLOR_NTP_SECTION_HEADER_RULE_LIGHT:
+ return IncreaseLightness(GetColor(COLOR_NTP_TEXT), 0.86);
+ }
+
return GetDefaultColor(id);
}
@@ -448,14 +464,6 @@ SkColor BrowserThemeProvider::GetDefaultColor(int id) {
return kDefaultColorNTPSectionLink;
case COLOR_NTP_SECTION_LINK_UNDERLINE:
return TintForUnderline(kDefaultColorNTPSectionLink);
- case COLOR_NTP_SECTION_HEADER_TEXT:
- return kDefaultColorNTPSectionHeaderText;
- case COLOR_NTP_SECTION_HEADER_TEXT_HOVER:
- return kDefaultColorNTPText;
- case COLOR_NTP_SECTION_HEADER_RULE:
- return kDefaultColorNTPSectionHeaderRule;
- case COLOR_NTP_SECTION_HEADER_RULE_LIGHT:
- return kDefaultColorNTPSectionHeaderRuleLight;
case COLOR_CONTROL_BACKGROUND:
return kDefaultColorControlBackground;
case COLOR_BUTTON_BACKGROUND:
« chrome/browser/resources/new_new_tab.css ('K') | « chrome/browser/resources/new_tab_theme.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698