Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1635)

Unified Diff: chrome/browser/dom_ui/ntp_resource_cache.cc

Issue 3340005: Make NTP look good with themes. (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/new_new_tab.css » ('j') | chrome/browser/resources/new_new_tab.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/ntp_resource_cache.cc
diff --git a/chrome/browser/dom_ui/ntp_resource_cache.cc b/chrome/browser/dom_ui/ntp_resource_cache.cc
index 8fd21f47943b68e65bd16f29e3f4f42a367b1144..56b12902fa54fab6d0eddcec8c3fe44eb64cd4c2 100644
--- a/chrome/browser/dom_ui/ntp_resource_cache.cc
+++ b/chrome/browser/dom_ui/ntp_resource_cache.cc
@@ -459,15 +459,12 @@ void NTPResourceCache::CreateNewTabCSS() {
subst2.push_back(SkColorToRGBAString(
color_section_header_text_hover)); // $$9
- // A fully transparent version of the background color --- used for gradients.
+ subst3.push_back(SkColorToRGBAString(color_section_header_rule)); // $$$1
subst3.push_back(SkColorToRGBAString(
- SkColorSetA(color_background, 0))); // $$$1
-
- // TODO(aa): It seems we could generate sensible defaults for all these colors
- // for better backward compat with old themes.
- subst3.push_back(SkColorToRGBAString(color_section_header_rule)); // $$$2
+ color_section_header_rule_light)); // $$$2
subst3.push_back(SkColorToRGBAString(
- color_section_header_rule_light)); // $$$3
+ SkColorSetA(color_section_header_rule, 0))); // $$$3
+
// Get our template.
static const base::StringPiece new_tab_theme_css(
« no previous file with comments | « no previous file | chrome/browser/resources/new_new_tab.css » ('j') | chrome/browser/resources/new_new_tab.css » ('J')

Powered by Google App Engine
This is Rietveld 408576698