Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 3333028: Improve the testing situation on Windows.... (Closed)

Created:
10 years, 3 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews
Visibility:
Public.

Description

Improve the testing situation on Windows. For now that involves disabling a lot of tests when they can't be run. I'm unsure about the ascii encoding, it fails here if I keep this call on a French UI. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -13 lines) Patch
M PRESUBMIT.py View 1 chunk +5 lines, -1 line 0 comments Download
M presubmit_support.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/fake_repos.py View 2 chunks +7 lines, -2 lines 0 comments Download
M tests/gclient_scm_test.py View 2 chunks +4 lines, -1 line 0 comments Download
M tests/gclient_smoketest.py View 19 chunks +45 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
10 years, 3 months ago (2010-09-10 17:51:08 UTC) #1
M-A Ruel
Ping, I'm stuck on svn with this change so I can't pipeline work to test ...
10 years, 3 months ago (2010-09-10 19:27:56 UTC) #2
bradn
10 years, 3 months ago (2010-09-10 19:32:18 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698