Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Side by Side Diff: PRESUBMIT.py

Issue 3333028: Improve the testing situation on Windows.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | presubmit_support.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for depot tools. 5 """Top-level presubmit script for depot tools.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into gcl. 8 details on the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 'git-cl-upload-hook')] 49 'git-cl-upload-hook')]
50 return [] 50 return []
51 51
52 def RunPylint(input_api, output_api): 52 def RunPylint(input_api, output_api):
53 import glob 53 import glob
54 files = glob.glob('*.py') 54 files = glob.glob('*.py')
55 # It's a python script 55 # It's a python script
56 files.append('git-try') 56 files.append('git-try')
57 # It uses non-standard pylint exceptions that makes pylint always fail. 57 # It uses non-standard pylint exceptions that makes pylint always fail.
58 files.remove('cpplint.py') 58 files.remove('cpplint.py')
59 proc = input_api.subprocess.Popen(['pylint', '-E'] + files) 59 try:
60 proc = input_api.subprocess.Popen(['pylint', '-E'] + files)
61 except WindowsError:
62 # It's windows, give up.
63 return []
60 proc.communicate() 64 proc.communicate()
61 if proc.returncode: 65 if proc.returncode:
62 return [output_api.PresubmitError('Fix pylint errors first.')] 66 return [output_api.PresubmitError('Fix pylint errors first.')]
63 return [] 67 return []
OLDNEW
« no previous file with comments | « no previous file | presubmit_support.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698