Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: PRESUBMIT.py

Issue 3333028: Improve the testing situation on Windows.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | presubmit_support.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
===================================================================
--- PRESUBMIT.py (revision 59107)
+++ PRESUBMIT.py (working copy)
@@ -56,7 +56,11 @@
files.append('git-try')
# It uses non-standard pylint exceptions that makes pylint always fail.
files.remove('cpplint.py')
- proc = input_api.subprocess.Popen(['pylint', '-E'] + files)
+ try:
+ proc = input_api.subprocess.Popen(['pylint', '-E'] + files)
+ except WindowsError:
+ # It's windows, give up.
+ return []
proc.communicate()
if proc.returncode:
return [output_api.PresubmitError('Fix pylint errors first.')]
« no previous file with comments | « no previous file | presubmit_support.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698