Issue 3331022: Fix presubmit check for depot_tools on linux and mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3331022: Fix presubmit check for depot_tools on linux and mac. (Closed)

Created:
10 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Fix presubmit check for depot_tools on linux and mac. The class WindowsError is only a builtin on Windows. Use OSError instead. Also make the exception more comprehensible on the other platforms when pylint is not installed. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59253

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	PRESUBMIT.py	View		1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages