Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: PRESUBMIT.py

Issue 3331022: Fix presubmit check for depot_tools on linux and mac. (Closed)
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 4ca213bb07a28538ef9014772f31db9b8779aca9..2c176fc06c2b637ebcc17e70debe4d12ee54128b 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -58,9 +58,13 @@ def RunPylint(input_api, output_api):
files.remove('cpplint.py')
try:
proc = input_api.subprocess.Popen(['pylint', '-E'] + files)
- except WindowsError:
- # It's windows, give up.
- return []
+ except OSError:
+ if input_api.platform == 'win32':
+ # It's windows, give up.
+ return []
+ else:
+ return [output_api.PresubmitError(
+ 'Please install pylint with "easy_install pylint"')]
proc.communicate()
if proc.returncode:
return [output_api.PresubmitError('Fix pylint errors first.')]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698