OLD | NEW |
1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Top-level presubmit script for depot tools. | 5 """Top-level presubmit script for depot tools. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for |
8 details on the presubmit API built into gcl. | 8 details on the presubmit API built into gcl. |
9 """ | 9 """ |
10 | 10 |
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
51 | 51 |
52 def RunPylint(input_api, output_api): | 52 def RunPylint(input_api, output_api): |
53 import glob | 53 import glob |
54 files = glob.glob('*.py') | 54 files = glob.glob('*.py') |
55 # It's a python script | 55 # It's a python script |
56 files.append('git-try') | 56 files.append('git-try') |
57 # It uses non-standard pylint exceptions that makes pylint always fail. | 57 # It uses non-standard pylint exceptions that makes pylint always fail. |
58 files.remove('cpplint.py') | 58 files.remove('cpplint.py') |
59 try: | 59 try: |
60 proc = input_api.subprocess.Popen(['pylint', '-E'] + files) | 60 proc = input_api.subprocess.Popen(['pylint', '-E'] + files) |
61 except WindowsError: | 61 except OSError: |
62 # It's windows, give up. | 62 if input_api.platform == 'win32': |
63 return [] | 63 # It's windows, give up. |
| 64 return [] |
| 65 else: |
| 66 return [output_api.PresubmitError( |
| 67 'Please install pylint with "easy_install pylint"')] |
64 proc.communicate() | 68 proc.communicate() |
65 if proc.returncode: | 69 if proc.returncode: |
66 return [output_api.PresubmitError('Fix pylint errors first.')] | 70 return [output_api.PresubmitError('Fix pylint errors first.')] |
67 return [] | 71 return [] |
OLD | NEW |