Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 3324012: Check for updates for a user script only if it has an update URL. (Closed)

Created:
10 years, 3 months ago by akalin
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, Raghu Simha, Erik does not do reviews, idana, pam+watch_chromium.org, Paweł Hajdan Jr., tim (not reviewing)
Visibility:
Public.

Description

Check for updates for a user script only if it has an update URL. This is 58907 modified for the 472 branch. This is also a modified revert of 52461. BUG=53639 TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58996

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M chrome/browser/extensions/extension_updater.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_updater_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/extension_util.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/extension_util_unittest.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
akalin
+aa for review
10 years, 3 months ago (2010-09-09 19:19:21 UTC) #1
Aaron Boodman
10 years, 3 months ago (2010-09-09 20:47:19 UTC) #2
lgtm, thanks for remembering to merge this

Powered by Google App Engine
This is Rietveld 408576698