Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: chrome/browser/sync/glue/extension_util.cc

Issue 3324012: Check for updates for a user script only if it has an update URL. (Closed)
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/extension_util.cc
diff --git a/chrome/browser/sync/glue/extension_util.cc b/chrome/browser/sync/glue/extension_util.cc
index 1fad37e1d3be6fccf8517a39976dd1518bd0f9d8..f1cd20fe7c050b0576cd42afaeb2d97505dab9c9 100644
--- a/chrome/browser/sync/glue/extension_util.cc
+++ b/chrome/browser/sync/glue/extension_util.cc
@@ -28,6 +28,12 @@ bool IsExtensionSyncable(const Extension& extension) {
return false;
}
+ // Reject converted user scripts that don't have an auto-update URL.
+ if (extension.converted_from_user_script() &&
+ extension.update_url().is_empty()) {
+ return false;
+ }
+
// TODO(akalin): Figure out if we need to allow some other types.
if (extension.location() != Extension::INTERNAL) {
// We have a non-standard location.
« no previous file with comments | « chrome/browser/extensions/extension_updater_unittest.cc ('k') | chrome/browser/sync/glue/extension_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698