Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2620)

Unified Diff: chrome/browser/extensions/extension_updater_unittest.cc

Issue 3324012: Check for updates for a user script only if it has an update URL. (Closed)
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_updater.cc ('k') | chrome/browser/sync/glue/extension_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_updater_unittest.cc
diff --git a/chrome/browser/extensions/extension_updater_unittest.cc b/chrome/browser/extensions/extension_updater_unittest.cc
index 0895501ff0df04037c0960d9824d3fd81f9b943d..416a39535712977c93977bb30b9e3d94a132d071 100644
--- a/chrome/browser/extensions/extension_updater_unittest.cc
+++ b/chrome/browser/extensions/extension_updater_unittest.cc
@@ -891,6 +891,9 @@ TEST(ExtensionUpdaterTest, TestManifestFetchesBuilderAddExtension) {
"", PendingExtensionInfo(GURL(), false, false, true, false));
EXPECT_TRUE(builder.GetFetches().empty());
+ // TODO(akalin): Test that extensions with empty update URLs
+ // converted from user scripts are rejected.
+
// Extensions with empty update URLs should have a default one
// filled in.
builder.AddPendingExtension(
« no previous file with comments | « chrome/browser/extensions/extension_updater.cc ('k') | chrome/browser/sync/glue/extension_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698