Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 332006: Remove the restriction that ChromeURLRequestContextGetter needs to be release... (Closed)

Created:
11 years, 2 months ago by eroman
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, ncarter (slow), idana, ben+cc_chromium.org, Paweł Hajdan Jr., darin (slow to review), tim (not reviewing)
Visibility:
Public.

Description

Cleanup some callers now that the restriction that ChromeURLRequestContextGetter be released from the IO thread is gone. This was an anoyance for consumers of URLRequestContextGetter, as they would play tricks doing manual AddRef/Release. The actual removal of this policy happened in: r32129. BUG=None Test=Existing tests don't crash/leak. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32488

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : sync to latest changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -57 lines) Patch
M chrome/browser/automation/automation_profile_impl.h View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/automation/automation_profile_impl.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/external_tab_container.cc View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/profile.h View 1 2 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/profile.cc View 1 2 7 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/sync/glue/http_bridge.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/http_bridge.cc View 1 2 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
11 years, 2 months ago (2009-10-23 10:59:48 UTC) #1
darin (slow to review)
LGTM! http://codereview.chromium.org/332006/diff/2004/2006 File chrome/browser/sync/glue/http_bridge.cc (right): http://codereview.chromium.org/332006/diff/2004/2006#newcode33 Line 33: if (MessageLoop::current() != io_loop_) { nit: consider ...
11 years, 2 months ago (2009-10-23 17:54:23 UTC) #2
eroman
Finally got around to committing this. Removed the chrome_url_request_context.{cc|h} files from this change, since r32129 ...
11 years, 1 month ago (2009-11-19 04:21:58 UTC) #3
darin (slow to review)
11 years, 1 month ago (2009-11-19 07:26:40 UTC) #4
OK

On Wed, Nov 18, 2009 at 8:21 PM, <eroman@chromium.org> wrote:

> Finally got around to committing this.
>
> Removed the chrome_url_request_context.{cc|h} files from this change, since
> r32129 already added the DeleteOnIOThread trait to URLRequestContextGetter.
>
> http://codereview.chromium.org/332006
>

Powered by Google App Engine
This is Rietveld 408576698